Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode - Don't write code after an unconditional C.


Perl-Critic documentation  | view source Contained in the Perl-Critic distribution.

Index


NAME

Top

Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode - Don't write code after an unconditional die, exit, or next.

AFFILIATION

Top

This Policy is part of the core Perl::Critic distribution.

DESCRIPTION

Top

This policy prohibits code following a statement which unconditionally alters the program flow. This includes calls to exit, die, return, next, last and goto. Due to common usage, croak and confess from Carp (Carp) are also included.

Code is reachable if any of the following conditions are true:

* Flow-altering statement has a conditional attached to it
* Statement is on the right side of an operator &&, ||, //, and, or, or err.
* Code is prefixed with a label (can potentially be reached via goto)
* Code is a subroutine

EXAMPLES

Top

  # not ok

  exit;
  print "123\n";

  # ok

  exit if !$xyz;
  print "123\n";

  # not ok

  for ( 1 .. 10 ) {
      next;
      print 1;
  }

  # ok

  for ( 1 .. 10 ) {
      next if $_ == 5;
      print 1;
  }

  # not ok

  sub foo {
      my $bar = shift;
      return;
      print 1;
  }

  # ok

  sub foo {
      my $bar = shift;
      return if $bar->baz();
      print 1;
  }




  # not ok

  die;
  print "123\n";

  # ok

  die;
  LABEL: print "123\n";

  # not ok

  croak;
  do_something();

  # ok

  croak;
  sub do_something {}




CONFIGURATION

Top

This Policy is not configurable except for the standard options.

SEE ALSO

Top

Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls

AUTHOR

Top

Peter Guzis <pguzis@cpan.org>

COPYRIGHT

Top


Perl-Critic documentation  | view source Contained in the Perl-Critic distribution.